Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always run hooks last for webpack@4 #142

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

alexander-akait
Copy link
Contributor

fixes #141

@alexander-akait
Copy link
Contributor Author

Will be great after merge release patch version 👍

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #142   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         109    110    +1     
  Branches       21     21           
=====================================
+ Hits          109    110    +1
Impacted Files Coverage Δ
lib/plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24acf95...7d0165e. Read the comment docs.

@alexander-akait
Copy link
Contributor Author

/cc @mastilver friendly ping

@mastilver mastilver merged commit f5cc167 into shellscape:master Apr 19, 2018
@mastilver
Copy link
Contributor

Published :)
Sorry for the delay

@alexander-akait alexander-akait deleted the issue-141 branch April 19, 2018 12:25
@mastilver mastilver mentioned this pull request Jun 10, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use stage: Infinity for webpack@4
3 participants