use sudo: required due to travis upgrade
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis has upgraded from trusty -> xenial to address Meltdown. There are issues with Chrome in Xenial that can currently be worked around with `sudo: required`. At some point this workaround may be removable. See travis-ci/travis-ci#8836
|
Thanks much for the heads up. I'll get the documentation updated to reflect that. |
blueimp
added a commit
to blueimp/JavaScript-Load-Image
that referenced
this pull request
Jan 23, 2018
shellscape
added a commit
to shellscape/loglevelnext
that referenced
this pull request
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis has upgraded from trusty -> xenial to address Meltdown. There are
issues with Chrome in Xenial that can currently be worked around with
sudo: required.At some point this workaround may be removable.
See travis-ci/travis-ci#8836
For Bugs and Features; did you add new tests?
No new tests needed, this fixes the Travis build infrastructure.
However, for a sample breaking build without this change: https://travis-ci.org/smalls/mocha-chrome/builds/326961711
And with this change: https://travis-ci.org/smalls/mocha-chrome/builds/327001070
Motivation / Use-Case
Travis has updated from Trusty to Xenial which is causing issues. This is their current recommended workaround; once they have a long-term fix, this change can be removed.
travis-ci/travis-ci#8836 for more information.
Breaking Changes
All current mocha-chrome & travis users may need to make similar changes in their
.travis.ymlfiles.Additional Info