fix(ui): ensure unhandled exceptions are not suppressed in tests #4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `errorHandler` configuration from test components to allow unhandled exceptions to surface during tests. This prevents silent error suppression and ensures test failures are properly reported.
…pport Added tagsApi integration across public key and firewall rule components to fetch tag data. Improved test coverage by mocking tagsApi responses in PublicKeyAdd, PublicKeyEdit, FirewallRuleAdd, and FirewallRuleEdit test specs. Exposed getPublicKeysList in PublicKeysList to support improved key management. Simplified the fetchPublicKeys function by removing redundant logic. Updated handleError utility to log errors only outside the test environment. Removed unnecessary store commits in NamespaceEdit test and improved test reliability for form actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
errorHandlerconfiguration from test components toallow unhandled exceptions to surface during tests.
This prevents silent error suppression and ensures test
failures are properly reported.