Add an option for Relative URLs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the contribution, LGTM for me 🙂 |
|
would you mind tagging a new release at some point? thanks! |
Yes sure, it's planned for Monday. |
|
Just released 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s3 plugin supports an option for creating the Index with relative URLs
I was surprised to find that when I attempted to use my helm repo from S3 (set up with CloudFront and https) that the charts didn't work because they were referencing an
s3://protocol URL. Using thereindexcommand manually - with--relativemade it functional.Rather than have to run a reindex in my GitHub action as an additional step, I'd like to see this option added to the action. This PR should accomplish that, and leaves the default functionality as it is today.