Skip to content

fix: Port does not work with promise config #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

fix: Port does not work with promise config #51

merged 1 commit into from
Aug 29, 2019

Conversation

@roni-frantchi
Copy link
Contributor

@roni-frantchi roni-frantchi commented Aug 29, 2019

The port used to be resolved assuming config is an object, while the change introduced in #24 allowed sending in a config Promise.

vladholubiev
vladholubiev approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@vladholubiev vladholubiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Roni!

@vladholubiev vladholubiev merged commit bb74c9c into shelfio:master Aug 29, 2019
@vladholubiev
Copy link
Member

vladholubiev commented Aug 29, 2019

@roni-frantchi I've just published https://github.com/shelfio/jest-dynamodb/releases/tag/v1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladholubiev vladholubiev vladholubiev approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roni-frantchi @vladholubiev