1.18.2 - Add Collapsible Entries #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very wip and kinda crap
…ed entry Also move to using Ordered Iterables for the ChildrenSet
Also minor other changes
I found that addEntry/addEntires added the NEW Entry at the given TARGET Entry Index which would really put the added entry before (Due to add will shift everything at or above the index to the right) so I made the ability to add a entry after or before a given entry.
|
I still need to implement this with Fluid Entrys and test with such btw |
This was referenced Jun 12, 2022
Merged
|
Thanks for this PR! I have incorporated this idea into da4bd5a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature to help with mods that add lots of blocks causing page total to go up causing a major inconvenience to the end user.
Very WIP and kinda cursed