Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct buffer source for rendering #1768

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

RaphiMC
Copy link

@RaphiMC RaphiMC commented Nov 17, 2024

Uses the buffer source of the GuiGraphics instead of getting it from Minecraft. This fixes the issue with ImmediatelyFast because ImmediatelyFast changes the internal buffer source.

Fixes #1753

@shedaniel
Copy link
Owner

shedaniel commented Nov 21, 2024

I see, so this fixes the weird translation errors in 1.21.2 with REI and ImmediatelyFast?

@RaphiMC
Copy link
Author

RaphiMC commented Nov 21, 2024

I see, so this fixes the weird translation errors in 1.21.2 with REI and ImmediatelyFast?

Yes

@RaphiMC
Copy link
Author

RaphiMC commented Dec 6, 2024

@shedaniel Is there anything blocking this PR from getting merged?

@shedaniel shedaniel merged commit 18baa61 into shedaniel:17.x-1.21.2 Dec 6, 2024
@shedaniel
Copy link
Owner

Sorry! Shouldn't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants