Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Custom user-definable categories for favorites. #388

Open
Katniss218 opened this issue Jul 23, 2020 · 4 comments
Open

[Feature] Custom user-definable categories for favorites. #388

Katniss218 opened this issue Jul 23, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request priority: low This does not immediately need to be resolved

Comments

@Katniss218
Copy link

Katniss218 commented Jul 23, 2020

Describe the solution you'd like
My vision is that the favorites panel would be separated by empty spaces about 2x the item's height. In this space would be a text that you can edit by pressing on it (?) (like any input field). Next to the text would be a "Delete Category" [-] button.

Alternatively, the entire panel could be paginated, and categories would switch between different sets of panels (that solution doesn't seem very intuitive).

Underneath all categories would be a section for uncategorized items (favs go here by default(?)). Items from deleted categories could also go here. An "Add Category" [+] button could also be here, under all the categories. Alternatively it could appear above all favorites.

We'd also need a way to move items between categories. This could be achieved in one of two ways.

  • Either on right-click instead of giving the item to the player, it'd pop up a menu with categories to move the favorite to,
  • or, a drag-and-drop method could be implemented (this could also be used for reordering favorites).

Additional context
This would probably be useful for mapmakers, who have a lot of custom items on their maps. Or maybe even for server owners. A nice place to keep every custom item handy and organized.

@Katniss218 Katniss218 added the enhancement New feature or request label Jul 23, 2020
@shedaniel
Copy link
Owner

superseding #362

@github-actions
Copy link

This issue is marked with stale as this issue had no activity in 60 days. This issue will not be automatically closed.

@github-actions github-actions bot added the stale label Sep 22, 2020
@shedaniel shedaniel removed the stale label Oct 18, 2020
@shedaniel shedaniel pinned this issue Oct 18, 2020
@github-actions
Copy link

This issue is marked with stale as this issue had no activity in 60 days. This issue will not be automatically closed.

@mk-pmb
Copy link

mk-pmb commented Jun 26, 2022

In case we get the extended "manage existing favorite item" context menu from #953, we could simplify the add/delete category button to a "Begin Category" string option of the favo entry. If it's non-empty, it starts a category by that name.

For UI, "starts a category" could mean to insert a headline like the ones used in the "+" menu ("Game Mode", "Weather", "Time"). Ideally, clicking that headline would toggle whether entries in this category are shown.

My hope is that if we make "Begin Category" a string property of the entry, the "move between categories" can be done with the existing drag-and-drop re-ordering, rather than requiring new code.

@shedaniel shedaniel added this to the REI 8.4 milestone Nov 28, 2022
@shedaniel shedaniel added the priority: low This does not immediately need to be resolved label Dec 12, 2022
@shedaniel shedaniel self-assigned this Mar 10, 2023
@shedaniel shedaniel removed this from the REI 8.4 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low This does not immediately need to be resolved
Projects
None yet
Development

No branches or pull requests

3 participants