Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Outsource favourites to separate file #1246

Closed
1 of 5 tasks
Joly0 opened this issue Nov 26, 2022 · 0 comments
Closed
1 of 5 tasks

[Feature] Outsource favourites to separate file #1246

Joly0 opened this issue Nov 26, 2022 · 0 comments
Labels
enhancement New feature or request note: pending release This issue has been resolved in development versions of REI priority: medium This issue or PR should be worked on soon-ish

Comments

@Joly0
Copy link

Joly0 commented Nov 26, 2022

What is your feature request?

In my opinion, it would be great, if favourites wouldnt be saved in the same file, as the configs for the mod itself.
Why? Quite easy: This mod is used in modpacks basically everytime and modpacks get updates. While modpacks update, they usually dont copy config files but rather recreate them or brings default ones while installing, so everytime a modpack updates, favourites are gone.
So what to do then? I guess a good approach might be to store them somewhere in the saves folder on a per world basis, because those files/folders remain while updating, because they usually get copied over.

What do you think this change is of?

  • Visual
  • Recipe Lookup
  • Cheat Mode
  • Plugin Integration / JEI Plugin Compatibility
  • Others
@Joly0 Joly0 added the enhancement New feature or request label Nov 26, 2022
@shedaniel shedaniel added this to the REI 8.4 milestone Nov 28, 2022
@shedaniel shedaniel added the priority: medium This issue or PR should be worked on soon-ish label Dec 10, 2022
shedaniel added a commit that referenced this issue Dec 24, 2022
@shedaniel shedaniel added the note: pending release This issue has been resolved in development versions of REI label Dec 24, 2022
shedaniel added a commit that referenced this issue Dec 25, 2022
shedaniel added a commit that referenced this issue Jun 1, 2023
shedaniel added a commit that referenced this issue Jul 16, 2023
shedaniel added a commit that referenced this issue Sep 1, 2023
shedaniel added a commit that referenced this issue Oct 18, 2023
shedaniel added a commit that referenced this issue Oct 24, 2023
shedaniel added a commit that referenced this issue Nov 5, 2023
shedaniel added a commit that referenced this issue Apr 15, 2024
shedaniel added a commit that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request note: pending release This issue has been resolved in development versions of REI priority: medium This issue or PR should be worked on soon-ish
Projects
None yet
Development

No branches or pull requests

2 participants