removed dict dependency and synced with Node.js implementation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the last
TODOwithin the code (ac21348) and removed the unnecessary dependency (0b358c3) as discussed in #4, still keeping the previous way of usage (808fdc3). I did not touch the poetry.lock file since i am not familiar with poetry. Perhaps the dependency should be removed there aswell.Additionally i synced the code to the current state of the Node.js implementation (0d852aa).
Tested on Ubuntu and Windows 11.
Sidenote: in case you release yet another version herafter, don't forget to update the
__version__variable within the code aswell ;)