Skip to content

Commit

Permalink
Disabling no wildcard imports rule
Browse files Browse the repository at this point in the history
Bandaid for pinterest#48
  • Loading branch information
shashachu committed May 22, 2019
1 parent cc6c59b commit 43bbd9e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ It's also [easy to create your own](#creating-a-reporter).
- 4 spaces for indentation
(unless a different `indent_size` value is set in .editorconfig (see [EditorConfig](#editorconfig) section for more));
- No semicolons (unless used to separate multiple statements on the same line);
- No wildcard / unused `import`s;
- No unused `import`s;
- No consecutive blank lines;
- No blank lines before `}`;
- No trailing whitespaces;
Expand All @@ -56,6 +56,13 @@ by passing the `--experimental` flag to `ktlint`.
- Indentation formatting
- Import ordering

## Disabled rules
- No wildcard `import`s;
- Annotation formatting;
- No underscores in package names;
- Braces required for if/else statements;
- Multi-line lambdas must name `it` param;

## EditorConfig

ktlint recognizes the following [.editorconfig](http://editorconfig.org/) properties (provided they are specified under `[*.{kt,kts}]`):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ class StandardRuleSetProvider : RuleSetProvider {
NoTrailingSpacesRule(),
NoUnitReturnRule(),
NoUnusedImportsRule(),
NoWildcardImportsRule(),
// Disabling because it is now allowed by the Jetbrains styleguide, although it is still disallowed by
// the Android styleguide.
// Re-enable when there is a way to globally disable rules
// See discussion here: https://github.com/pinterest/ktlint/issues/48
// NoWildcardImportsRule(),
ParameterListWrappingRule(),
SpacingAroundColonRule(),
SpacingAroundCommaRule(),
Expand Down

0 comments on commit 43bbd9e

Please sign in to comment.