Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce testing #2

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Introduce testing #2

merged 1 commit into from
Jun 2, 2020

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Jun 2, 2020

As a testing strategy we'll generate apps that pretend to be buildpacks using the "inline" buildpack. We can then use this along with Hatchet to test our buildpack behavior.

Adding in these tests exposed a problem with the previous logic. There was a bug where if a Procfile existed but didn't contain a release: designation then the runtime check wouldn't be executed.

As a testing strategy we'll generate apps that pretend to be buildpacks using the "inline" buildpack. We can then use this along with Hatchet to test our buildpack behavior.

Adding in these tests exposed a problem with the previous logic. There was a bug where if a Procfile existed but didn't contain a `release:` designation then the runtime check wouldn't be executed.
@schneems schneems merged commit 272395b into master Jun 2, 2020
@schneems
Copy link
Contributor Author

schneems commented Jun 2, 2020

This accidentally runs all tests against master branch. Need to also include this commit: e76ff1a

@schneems
Copy link
Contributor Author

schneems commented Jun 3, 2020

Rspec will truncate output if it is too long. You can set it to not do this by configuring:

  config.expect_with :rspec do |c|
    c.max_formatted_output_length = Float::INFINITY
    c.syntax = :expect
  end

I'm also asking how to disable inspect-ing the output of the tests at rspec/rspec-expectations#1188

@edmorley edmorley deleted the schneems/tests branch March 2, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant