Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NHibernate setup, see #61 #123

Merged
merged 2 commits into from
Jul 29, 2015

Conversation

cd21h
Copy link

@cd21h cd21h commented Jul 24, 2015

  • Replace NHibernateSession with NHibernateSessionFactoryBuilder, fixes NHibernate event listeners registered through xml gets removed #54
  • ValidatableObject now requires ValidationContext;
  • HasUniqueDomainSignatureAttribute now requires ValidationContext;
  • DataAnnotationsEventListener how provides IServiceProvider with ISession;
  • TardisBank - use CastleWindsor to register ISession and ISessionFactory;
  • TardisBank - update CastleWindsor installers.
  • Use DependencyResolver in ASP.NET MVC
  • Inherit ILinqRepository from IRepository

* Add NHibernateSessionFactoryBuilder, also fixes sharparchitecture#54
* Replace NHibernateSession with NHibernateSessionFactoryBuilder, see sharparchitecture#61
* ValidatableObject now requires ValidationContext;
* HasUniqueDomainSignatureAttribute now requires ValidationContext;
* DataAnnotationsEventListener how provides IServiceProvider with ISession;
* TardisBank - use CastleWindsor to register ISession and ISessionFactory;
* TardisBank - update CastleWindsor installers.
* Use DependencyResolver in ASP.NET MVC
* Inherit ILinqRepository from IRepository
@@ -75,6 +62,18 @@ protected void Application_Start()
BundleConfig.RegisterBundles(BundleTable.Bundles);
}

ISessionFactory CreateSessionFactory(IKernel kernel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shatl would be better to move the NHibernate registration stuff into it's own installer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seif Yes, but I'd do this after we review multi-tenancy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shatl not sure how multi tenancy would affect the location of this code (I think multi tenancy is way far down the line, unless you meant multi database which would be sooner), but we can still add whatever functionality we want to the Installer instead of having this code here until then.

@seif
Copy link
Member

seif commented Jul 24, 2015

Nice one @Shatl :)

* Move NHibernate initialization to Windsor installer;
* Move Windsor FilterAttribute installation to SharpArch.Web.Mvc.Castle
@cd21h
Copy link
Author

cd21h commented Jul 29, 2015

@seif Updated

seif added a commit that referenced this pull request Jul 29, 2015
@seif seif merged commit d2f65bc into sharparchitecture:develop Jul 29, 2015
@cd21h cd21h deleted the feature/SA61 branch November 27, 2015 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants