Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chrono with just time. #1190

Closed
wants to merge 1 commit into from

Conversation

tmccombs
Copy link
Collaborator

And ugprade to time 0.3

@tmccombs tmccombs marked this pull request as ready for review November 30, 2022 09:14
tmccombs added a commit that referenced this pull request Nov 30, 2022
Because chrono was depending on an older version of time, and we don't
actually need it with recent versions of chrono.

Relates-To: #1188
Alernative-To: #1190
And ugprade to time 0.3
tmccombs added a commit that referenced this pull request Dec 1, 2022
Because chrono was depending on an older version of time, and we don't
actually need it with recent versions of chrono.

Relates-To: #1188
Alernative-To: #1190
tmccombs added a commit that referenced this pull request Dec 3, 2022
Because chrono was depending on an older version of time, and we don't
actually need it with recent versions of chrono.

Relates-To: #1188
Alernative-To: #1190
@tmccombs tmccombs closed this Dec 3, 2022
@azzamsa
Copy link

azzamsa commented Jun 20, 2023

@tmccombs. Not being able to get the local offset in parallel is why you switch back to Chrono?

@tmccombs
Copy link
Collaborator Author

The master branch never switched away from chrono. But yes, the problem with getting the offset in parallel was one reason we stuck with chrono. Specifically because it rust runs testa in parallel by default, so we couldn't get the offset in unit tests without disabling parallel test runs

@azzamsa
Copy link

azzamsa commented Jun 21, 2023

Thanks for taking the time to answer.

I port some of my crates to time months ago. I can live with --test-threads 1 (nextest-rs/nextest#715). But lately, there have been cases where my user wants to use Tokio spawn but it fails because of the local offset issue. So, I plan to port it back to Chrono sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants