Add JQ syntax highlighting #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
reviewed
Feb 12, 2022
There was a problem hiding this comment.
Thanks for your contribution!
The syntax here doesn't self-embed in shell scripts that call the
jqcommand, but if that were a thing to implement, it would probably be more commonly used.
To me, that sounds like a great idea! Maybe we can add it as a patch.
Please could you add a CHANGELOG.md entry for this change as per https://github.com/sharkdp/bat/blob/master/CONTRIBUTING.md.
Also, note that you don't need to include the syntaxes.bin file in the PR. :) this is mentioned at step 7 in https://github.com/sharkdp/bat/blob/master/doc/assets.md
|
Whoops, sorry for only skimming the directions. 😳 Removed the |
keith-hall
reviewed
Feb 12, 2022
keith-hall
approved these changes
Feb 12, 2022
sharkdp
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has 13k downloads on package control: https://packagecontrol.io/packages/JQ%20Syntax
JQ is a pretty well-known tool, so, hopefully this isn't too controversial to add. A lot of people don't know that JQ can load scripts directly from files, however, and may not end up actually using the syntax highlighting. The syntax here doesn't self-embed in shell scripts that call the jq command, but if that were a thing to implement, it would probably be more commonly used.