Add hosted footer functionality #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SariSaar
commented
May 15, 2023
SariSaar
commented
- Create FooterContainer
- Add new section for footer
- Add new blocks for footer and social media link
- Add new primitives for SocialMediaLink and Text
- Replace old Footer component with dynamic FooterContainer
- Remove hard-coded Footer component
- Add code splitting to default content page PageBuilder imports
and restrict editing if both listingType and unitType do not match
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
src/containers/LandingPage/__snapshots__/LandingPage.test.js.snap
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 15, 2023
src/containers/PageBuilder/BlockBuilder/BlockSocialMediaLink/BlockSocialMediaLink.js
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
Gnito
reviewed
May 15, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.js
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 15, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.js
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 15, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.js
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 15, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.module.css
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 15, 2023
| } | ||
|
|
||
| .linkList { | ||
| list-style-type: none; |
There was a problem hiding this comment.
Add something about Footer to SectionBuilder/README.md
There are some special rules like this one. I.e. "list-item" doesn't look like a default bullet point list, because the expected use case is to create a list of links with that particular markdown syntax.
There was a problem hiding this comment.
Have you tested other markdown syntax in the footer - does it look OK?
There was a problem hiding this comment.
I tested markdown syntax in the footer, and bolding, italics and block quotes work. Heading levels work apart from font size, i.e. headings get bolding and added margin but stay the same size.
How detailed should the README.md explanation be on SectionFooter?
Gnito
reviewed
May 15, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.module.css
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 16, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.module.css
Outdated
Show resolved
Hide resolved
Gnito
reviewed
May 16, 2023
src/containers/PageBuilder/SectionBuilder/SectionFooter/SectionFooter.module.css
Outdated
Show resolved
Hide resolved
|
Cherry-picked comments to a new PR #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.