Move and refactor LandingPage components #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
move-and-refactor-landingpage-components
branch
from
bf18386
to
c2a7a0f
Compare
Gnito
changed the title
Gnito
commented
Sep 7, 2021
| @@ -27,6 +28,14 @@ | |||
| } | |||
| } | |||
|
|
|||
| .heroRoot { | |||
| @apply --backgroundImage; | |||
There was a problem hiding this comment.
This had to be passed from LandingPage, since --backgroundImage PropertySet contained relative path to the image. Since SectionHero component is now deeper in the directory tree, it doesn't use the --backgroundImage PropertySet directly but through rootClassName.
Gnito
force-pushed
the
move-and-refactor-landingpage-components
branch
2 times, most recently
from
d33c388
to
ff486e3
Compare
Gnito
force-pushed
the
move-and-refactor-landingpage-components
branch
from
ff486e3
to
0876755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some components have been moved under LandingPage container:
Deleted completely: