Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimated stock tx #67

Merged
merged 14 commits into from
Aug 4, 2021
Merged

Estimated stock tx #67

merged 14 commits into from
Aug 4, 2021

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Aug 3, 2021 •
edited
Loading

This PR adds support for product breakdowns in the estimated order breakdown.

  • Move component so it can be shared with the upcoming ProductOrderForm
  • Rename component to indicate that it is for customers only
  • Make bookings optional in the breakdown
  • Refactor line item rendering to only deal with line items instead of the full transaction

Screenshot from Styleguide

EstimatedCustomerBreakdownMaybe

@kpuputti kpuputti requested a review from Gnito August 4, 2021 12:08
Gnito
Gnito approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added couple of suggestion for better naming of examples.

@kpuputti kpuputti merged commit 9cf7255 into main Aug 4, 2021
@kpuputti kpuputti deleted the estimated-stock-tx branch August 4, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Gnito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpuputti @Gnito