Fix padding problem in EditListingWizard #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem with paddings on EditListingWizard. For some reason, the padding for specific media query in .panel class of
EditListingWizard.module.csswas overwritten by the css of each panel. To avoid this issue, I moved handling the padding to one place which is nowEditListingWizard.module.css. I couldn't see any reason why these paddings should be handled in each panel separately.It seems that the issue started to happen after the EditListingWizard related components like panels was moved under EditListingPage from the shared components folder. I think this changed the order in which the CSS is loaded and that caused the padding on individual panels to overwrite the generic padding rules.
Before:
After:
