Use dayCountAvailableForBooking config in FieldDateAndTimeInput #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
Jan 4, 2021
| // A maximum number of days forwards during which a booking can be made. | ||
| // This is limited due to Stripe holding funds up to 90 days from the | ||
| // moment they are charged. Also note that available time slots can only | ||
| // be fetched for 180 days in the future. |
There was a problem hiding this comment.
Could you also update the comment here (and in config.js) about time-slot query:
https://www.sharetribe.com/api-reference/marketplace.html#query-time-slots
It seems that the 180 day limit has been pushed forward.
Gnito
reviewed
Jan 4, 2021
There was a problem hiding this comment.
Looks good, but I think it would be good to update the code comments at this point (they are not in sync with API).
So, maybe adding a link to API Reference and Stripe would make sense:
https://stripe.com/docs/connect/account-balances#holding-funds
OtterleyW
force-pushed
the
align-max-timeslots-range
branch
from
1437b59
to
61ad64d
Compare
… FieldDateAndTimeInput
OtterleyW
force-pushed
the
align-max-timeslots-range
branch
from
61ad64d
to
f6356e0
Compare
Gnito
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dayCountAvailableForBooking config instead of hard-coded value in FieldDateAndTimeInput so that it matches the date range that is used in react-dates components.
Earlier the dayCountAvailableForBooking was set to 90 but the MAX_TIME_SLOTS_RANGE was 180 and the calendar looked broken because after the first 3 months the timeslots appeared as blocked. Also, if you selected the date far enough in the future, checking the timeslots broke and all the dates seem to be available.
If the dayCountAvailableForBooking and MAX_TIME_SLOTS_RANGE is the same, showing the timeslots works correctly. Here's both 90 and 180 days options:
And since there's the limitation that by default Stripe is holding funds up to 90 days from the moment they are charged, I think keeping the default range in 90 would be the best solution.