Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong booking title on listing page #987

Merged
merged 2 commits into from
Dec 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ way to update this template, but currently, we follow a pattern:

## Upcoming version 2018-XX-XX

- [fix] Fix wrong booking title on listing page that has been introduced in #969.
[#987](https://github.com/sharetribe/flex-template-web/pull/987)
- [fix] yarn.lock file was not up to date
[#986](https://github.com/sharetribe/flex-template-web/pull/986)
- [add] Add an image of fork button to the deploy to production guide.
Expand Down
5 changes: 2 additions & 3 deletions src/containers/ListingPage/ListingPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,8 @@ export class ListingPageComponent extends Component {
</span>
);

const bookingTitle = intl.formatMessage(
{ id: 'ListingPage.bookingSubTitle' },
{ title: richTitle }
const bookingTitle = (
<FormattedMessage id="ListingPage.bookingTitle" values={{ title: richTitle }} />
);
const bookingSubTitle = intl.formatMessage({ id: 'ListingPage.bookingSubTitle' });

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,22 @@ exports[`ListingPage matches snapshot 1`] = `
onSubmit={[Function]}
subTitle="ListingPage.bookingSubTitle"
timeSlots={null}
title="ListingPage.bookingSubTitle"
title={
<FormattedMessage
id="ListingPage.bookingTitle"
values={
Object {
"title": <span>

listing1

title

</span>,
}
}
/>
}
unitType="line-item/night"
/>
</div>
Expand Down