Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable requesting to book straight from enquiry #976

Merged
merged 15 commits into from
Dec 20, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ way to update this template, but currently, we follow a pattern:
[#985](https://github.com/sharetribe/flex-template-web/pull/985)
- [remove] Remove the default built-in email templates. Built-in email templates can be edited in
Console. [#983](https://github.com/sharetribe/flex-template-web/pull/983)
- [add] Enable booking a listing straight from an enquiry
[#976](https://github.com/sharetribe/flex-template-web/pull/976)
- [change] Extract SectionBooking to a distinct component from ListingPage.
[#969](https://github.com/sharetribe/flex-template-web/pull/969)

Expand Down
4 changes: 2 additions & 2 deletions src/components/BookingPanel/BookingPanel.example.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const Default = {
props: {
className: css.example,
listing: createListing('listing_1'),
handleBookingSubmit: values => console.log('Submit:', values),
onSubmit: values => console.log('Submit:', values),
title: <span>Booking title</span>,
subTitle: 'Hosted by Author N',
authorDisplayName: 'Author Name',
Expand All @@ -22,7 +22,7 @@ export const WithClosedListing = {
props: {
className: css.example,
listing: createListing('listing_1', { state: LISTING_STATE_CLOSED }),
handleBookingSubmit: values => console.log('Submit:', values),
onSubmit: values => console.log('Submit:', values),
title: <span>Booking title</span>,
subTitle: 'Hosted by Author N',
authorDisplayName: 'Author Name',
Expand Down
6 changes: 3 additions & 3 deletions src/components/BookingPanel/BookingPanel.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const BookingPanel = props => {
listing,
isOwnListing,
unitType,
handleBookingSubmit,
onSubmit,
title,
subTitle,
authorDisplayName,
Expand Down Expand Up @@ -116,7 +116,7 @@ const BookingPanel = props => {
className={css.bookingForm}
submitButtonWrapperClassName={css.bookingDatesSubmitButtonWrapper}
unitType={unitType}
onSubmit={handleBookingSubmit}
onSubmit={onSubmit}
price={price}
isOwnListing={isOwnListing}
timeSlots={timeSlots}
Expand Down Expand Up @@ -167,7 +167,7 @@ BookingPanel.propTypes = {
listing: propTypes.listing.isRequired,
isOwnListing: bool,
unitType: propTypes.bookingUnitType,
handleBookingSubmit: func.isRequired,
onSubmit: func.isRequired,
title: oneOfType([node, string]).isRequired,
subTitle: oneOfType([node, string]),
authorDisplayName: string.isRequired,
Expand Down
45 changes: 28 additions & 17 deletions src/components/TransactionPanel/TransactionPanel.css
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,11 @@
}

.avatarWrapperCustomerDesktop {
display: none;
composes: avatarWrapperMobile;

@media (--viewportLarge) {
display: block;
margin-left: 48px;
}
}
Expand Down Expand Up @@ -171,25 +173,27 @@
}

.detailCard {
display: none;

position: sticky;
top: -200px; /* This is a hack to showcase how the component would look when the image isn't sticky */
width: 409px;
background-color: var(--matterColorLight);
border: 1px solid var(--matterColorNegative);
border-radius: 2px;

@media (--viewportLarge) {
display: block;
position: sticky;
top: -200px; /* This is a hack to showcase how the component would look when the image isn't sticky */
width: 409px;
background-color: var(--matterColorLight);
border: 1px solid var(--matterColorNegative);
border-radius: 2px;
z-index: 1;
}
}

.detailCardImageWrapper {
display: none;

/* Layout */
display: block;
width: 100%;
position: relative;

@media (--viewportLarge) {
display: block;
}
}

.detailCardHeadings {
Expand All @@ -202,10 +206,6 @@
margin-bottom: 37px;
}
}
.detailCardHeadingsProvider {
composes: detailCardHeadings;
margin-top: 24px;
}

.detailCardTitle {
margin-bottom: 10px;
Expand All @@ -218,13 +218,12 @@

.detailCardSubtitle {
@apply --marketplaceH5FontStyles;
color: var(--matterColorAnti);

margin-top: 0;
margin-bottom: 0;

@media (--viewportLarge) {
margin-top: 1px;
margin-top: 9px;
margin-bottom: 0;
}
}
Expand All @@ -250,6 +249,14 @@
}
}

.breakdownContainer {
display: none;

@media (--viewportLarge) {
display: block;
}
}

.breakdown {
margin: 14px 24px 0 24px;

Expand Down Expand Up @@ -408,3 +415,7 @@
top: 151px;
}
}

.bookingPanel {
margin: 16px 48px 48px 48px;
}
76 changes: 62 additions & 14 deletions src/components/TransactionPanel/TransactionPanel.helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { createSlug, stringify } from '../../util/urlHelpers';
import {
ActivityFeed,
BookingBreakdown,
BookingPanel,
ExternalLink,
NamedLink,
PrimaryButton,
Expand Down Expand Up @@ -89,7 +90,6 @@ export const FeedSection = props => {
export const AddressLinkMaybe = props => {
const { transaction, transactionRole, currentListing } = props;

const isProvider = transactionRole === 'provider';
const isCustomer = transactionRole === 'customer';
const txIsAcceptedForCustomer = isCustomer && txHasBeenAccepted(transaction);

Expand All @@ -106,7 +106,7 @@ export const AddressLinkMaybe = props => {
const fullAddress =
typeof building === 'string' && building.length > 0 ? `${building}, ${address}` : address;

return (isProvider || txIsAcceptedForCustomer) && hrefToGoogleMaps ? (
return txIsAcceptedForCustomer && hrefToGoogleMaps ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. A provider could see the location of his listing all the time, but this works too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gnito I don't quite follow. The idea is to hide the address link from the provider.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyyder provider owns the listing - he knows where it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and that's why it's not relevant to show the address link to the provider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved IRL: When to show the listing location link has been a topic of a debate also before and probably continues to be one in the future. For now, we'll only show it only to customers after a booking has been accepted.

<p className={css.address}>
<ExternalLink href={hrefToGoogleMaps}>{fullAddress}</ExternalLink>
</p>
Expand All @@ -115,17 +115,19 @@ export const AddressLinkMaybe = props => {

// Functional component as a helper to build BookingBreakdown
export const BreakdownMaybe = props => {
const { className, rootClassName, transaction, transactionRole } = props;
const { className, rootClassName, breakdownClassName, transaction, transactionRole } = props;
const loaded = transaction && transaction.id && transaction.booking && transaction.booking.id;

const classes = classNames(rootClassName || css.breakdown, className);
const classes = classNames(rootClassName || className);
const breakdownClasses = classNames(css.breakdown, breakdownClassName);

return loaded ? (
<div>
<div className={classes}>
<h3 className={css.bookingBreakdownTitle}>
<FormattedMessage id="TransactionPanel.bookingBreakdownTitle" />
</h3>
<BookingBreakdown
className={classes}
className={breakdownClasses}
userRole={transactionRole}
unitType={config.bookingUnitType}
transaction={transaction}
Expand All @@ -152,16 +154,62 @@ const createListingLink = (listing, label, searchParams = {}, className = '') =>
}
};

// Functional component as a helper to build ActionButtons for
// provider when state is preauthorized
export const OrderActionButtonMaybe = props => {
const { className, rootClassName, canShowButtons, listing } = props;
// Functional component as a helper to build detail card headings
export const DetailCardHeadingsMaybe = props => {
const { transaction, transactionRole, listing, listingTitle, subTitle } = props;

const title = <FormattedMessage id="TransactionPanel.requestToBook" />;
const listingLink = createListingLink(listing, title, { book: true }, css.requestToBookButton);
const classes = classNames(rootClassName || css.actionButtons, className);
const isCustomer = transactionRole === 'customer';
const canShowDetailCardHeadings = isCustomer && !txIsEnquired(transaction);

return canShowDetailCardHeadings ? (
<div className={css.detailCardHeadings}>
<h2 className={css.detailCardTitle}>{listingTitle}</h2>
<p className={css.detailCardSubtitle}>{subTitle}</p>
<AddressLinkMaybe
transaction={transaction}
transactionRole={transactionRole}
currentListing={listing}
/>
</div>
) : null;
};

// Functional component as a helper to build a BookingPanel
export const BookingPanelMaybe = props => {
const {
authorDisplayName,
transaction,
transactionRole,
listing,
listingTitle,
subTitle,
provider,
onSubmit,
onManageDisableScrolling,
timeSlots,
fetchTimeSlotsError,
} = props;

return canShowButtons ? <div className={classes}>{listingLink}</div> : null;
const isProviderLoaded = !!provider.id;
const isProviderBanned = isProviderLoaded && provider.attributes.banned;
const isCustomer = transactionRole === 'customer';
const canShowBookingPanel = isCustomer && txIsEnquired(transaction) && !isProviderBanned;

return canShowBookingPanel ? (
<BookingPanel
className={css.bookingPanel}
isOwnListing={false}
listing={listing}
handleBookingSubmit={() => console.log('submit')}
title={listingTitle}
subTitle={subTitle}
authorDisplayName={authorDisplayName}
onSubmit={onSubmit}
onManageDisableScrolling={onManageDisableScrolling}
timeSlots={timeSlots}
fetchTimeSlotsError={fetchTimeSlotsError}
/>
) : null;
};

// Functional component as a helper to build ActionButtons for
Expand Down
Loading