Fix multi select filters in filter panel #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
approved these changes
Aug 1, 2018
Check that filter props are available before resolving initial values for the corresponding filter param.
Pass in the id of the parent component of the filter to achieve input ID uniqueness.
lyyder
force-pushed
the
fix-filter-panel
branch
from
80ca0b9
to
d1369ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in search filters that was caused by the multi select filter input IDs not being unique. This resulted in multiple filter input elements with same IDs if search filters panel is in use as it uses the same filter components as the mobile filter view. The result of this was that when selecting an option in a multi select filter in the search filters panel a mobile search filter callback was fired as the panel and the mobile view share the same filter components.
NOTICE!
When merging this PR to a downstream project, remember to pass the
idprop to all theSelectMultipleFilterandSelectMultipleFilterPlaincomponents inSearchFilters,SearchFiltersMobile,SearchFiltersPaneland other places where you have used them.