-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microcopy from Assets API #1510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
translations-from-assets
branch
4 times, most recently
from
May 12, 2022 10:12
35cd0b0
to
a097e6c
Compare
OtterleyW
reviewed
May 12, 2022
Gnito
force-pushed
the
translations-from-assets
branch
from
May 13, 2022 10:05
a097e6c
to
f365bed
Compare
1 task
…f found from envs
saves version to preloaded state. Hydration (CSR) fetches assets with version which most often hits broser's cache.
…as fallback value)
Gnito
force-pushed
the
translations-from-assets
branch
from
May 16, 2022 11:39
f365bed
to
2f62efc
Compare
This was referenced May 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How this works:
Production mode (
yarn start
andyarn run dev-server
):sdk.assetByAlias
loadData
call if the route specifies it and<ServerApp>
and pass translations as props.sdk.assetByVersion
.loadData
call<ClientApp>
and pass translations as props.Side note:
Development mode (
yarn run dev
):sdk.assetByAlias
loadData
call<ClientApp>
and pass translations as props.Other:
CSP: Asset Delivery API uses a new domain.
assetCdnBaseUrl is mainly used for our internal dev environment.
app.js: some refactoring to improve readability
SectionHero: SSR delays animation 3s, CSR swaps it to happen immediately
Update translation files (de.json, es.json, fr.json) to include all the keys defined in en.json
(and use English translation as value for those untranslated keys)