Modal: portal could use hack for 100vh to have correct height #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
fix-modals-on-mobile-safari
branch
from
989d4ed
to
593a96f
Compare
Gnito
force-pushed
the
fix-modals-on-mobile-safari
branch
from
593a96f
to
4a99177
Compare
Gnito
force-pushed
the
fix-modals-on-mobile-safari
branch
from
4a99177
to
af4e833
Compare
Gnito
force-pushed
the
fix-modals-on-mobile-safari
branch
from
af4e833
to
5e2678a
Compare
Gnito
force-pushed
the
fix-modals-on-mobile-safari
branch
from
5e2678a
to
b25cdf3
Compare
Gnito
force-pushed
the
fix-modals-on-mobile-safari
branch
from
b25cdf3
to
c975798
Compare
This was referenced Mar 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portal version of Modals couldn't use 100vh on mobile Safari. Safari changes the window's height based on if the location bar is squeezed or not (and that depends on scroll-effect).
Basically, this fix:
https://css-tricks.com/the-trick-to-viewport-units-on-mobile/#css-custom-properties-the-trick-to-correct-sizing