Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkout process #1486

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Fix checkout process #1486

merged 5 commits into from
Dec 2, 2021

Conversation

Gnito
Copy link
Contributor

@Gnito Gnito commented Dec 1, 2021

Issues:

  • Submit button was enabled prematurely for onetime payments.
    It didn't check if stripeElements aka card number field was filled.
  • Changing from onetime payment to default card was not working correctly in case of error (e.g. network error).
  • Calling stripe.confirmCardPayment when status is requires_capture is unnecessary.

    400 "You cannot confirm this PaymentIntent because it has a status of requires_capture. Only a PaymentIntent with one of the following statuses may be confirmed: requires_confirmation, requires_action."

Note: these are cherry-picked commits from FTW-product:

@Gnito Gnito temporarily deployed to sharetribe-starter-app December 1, 2021 14:59 Inactive
@Gnito Gnito requested a review from kpuputti December 1, 2021 15:16
Copy link
Contributor

@kpuputti kpuputti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the Stripe/PI flow, but the code looks clean in general.

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants