Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modal close button text/icon alignment #1476

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Fix modal close button text/icon alignment #1476

merged 3 commits into from
Oct 4, 2021

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Oct 4, 2021 •
edited
Loading

This PR fixes the vertical alignment of the modal close button text and icon.

Before

close-before

After

close-after

@kpuputti kpuputti requested a review from Gnito October 4, 2021 07:55
Gnito
Gnito approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpuputti kpuputti merged commit 878c782 into master Oct 4, 2021
@kpuputti kpuputti deleted the fix-modal-close-text-alignment branch October 4, 2021 09:52
This was referenced Dec 2, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Gnito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpuputti @Gnito