Fix: LoadableComponentErrorBoundary should be used in prod, not in dev #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
fix-loadablecomponenterrorboundary
branch
from
6909e72
to
f9a199e
Compare
This was referenced Apr 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadableComponentErrorBoundary helps in situations, where production build changes in the server and long-living client app tries to fetch code chunks that don't exist anymore.
Note: in development mode with Hot Module Reloading (HMR) in use, this can actually cause error loops with message:
"React will try to recreate this component tree from scratch using the error boundary you provided"