Add LoadableComponentErrorBoundary for handling ChunkLoadErrors #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
add-error-boundary
branch
from
b08d280
to
56694e4
Compare
OtterleyW
commented
Mar 3, 2021
| @@ -11,7 +11,7 @@ import css from './LayoutSingleColumn.module.css'; | |||
|
|
|||
| const prepareChildren = children => { | |||
| const childrenCount = React.Children.count(children); | |||
| if (!(childrenCount === 3 || childrenCount === 4)) { | |||
| if (!(childrenCount === 2 || childrenCount === 3)) { | |||
There was a problem hiding this comment.
I guess this has been a copy paster error from LayoutSideNavigation? Before the LoadableComponentErrorBoundaryPage we didn't have any page that would use LayoutSingleColumn without footer so that's why this has maybe not been noticed.
There was a problem hiding this comment.
Change also that ”Menu” on next line :)
OtterleyW
changed the title
OtterleyW
commented
Mar 3, 2021
| const landingPagePath = pathByRouteName('LandingPage', routeConfiguration()); | ||
| const handleOnClick = () => { | ||
| if (typeof window !== 'undefined') { | ||
| window.location = landingPagePath; |
There was a problem hiding this comment.
We want the app to make full page refresh when navigating back LandingPage. I'm not sure if there is some other (better) way to trigger that or if this is ok.
Gnito
reviewed
Mar 3, 2021
src/components/LoadableComponentErrorBoundary/LoadableComponentErrorBoundaryPage.js
Outdated
Show resolved
Hide resolved
Gnito
reviewed
Mar 3, 2021
src/components/LoadableComponentErrorBoundary/LoadableComponentErrorBoundary.module.css
Outdated
Show resolved
Hide resolved
OtterleyW
force-pushed
the
add-error-boundary
branch
from
56694e4
to
5792594
Compare
OtterleyW
force-pushed
the
add-error-boundary
branch
from
b1469fe
to
5792594
Compare
OtterleyW
force-pushed
the
add-error-boundary
branch
from
5792594
to
3a2fd45
Compare
This was referenced Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ErrorBoundary for showing the error page if there's a ChunkLoadError