Remove unintended Lodash usage, unspecified window-scope calls and unused vars #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
code-splitting-dataloader-api
branch
from
6ab8f06
to
6964a7b
Compare
Gnito
force-pushed
the
clean-unused-vars-and-follow-eslint-rules
branch
from
4e09f3e
to
cbc459c
Compare
kpuputti
approved these changes
Feb 16, 2021
Gnito
force-pushed
the
code-splitting-dataloader-api
branch
from
6964a7b
to
77e63ef
Compare
Gnito
force-pushed
the
clean-unused-vars-and-follow-eslint-rules
branch
from
cbc459c
to
2325852
Compare
Gnito
force-pushed
the
code-splitting-dataloader-api
branch
from
77e63ef
to
caab97f
Compare
Gnito
force-pushed
the
clean-unused-vars-and-follow-eslint-rules
branch
from
2325852
to
7916801
Compare
Gnito
force-pushed
the
code-splitting-dataloader-api
branch
from
caab97f
to
899ccf7
Compare
Gnito
force-pushed
the
clean-unused-vars-and-follow-eslint-rules
branch
from
7916801
to
37226e2
Compare
Gnito
force-pushed
the
clean-unused-vars-and-follow-eslint-rules
branch
from
37226e2
to
eb33026
Compare
Gnito
changed the title
This was referenced Feb 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested ejection. Codebase needs few changes:
scripts/directory needs to be renamed (Not made in this branch)commit: src/util/googleMaps.js: google.maps is on window's scope.
commit: SearchMap/SearchMapWithGoogleMaps.js: remove unintended Lodash usage
In addition, there are lots of eslint warnings - and this PR cleans them.
Removed FlashNotification.duck.js - it was not used at all.