Move OIDC .well-known/* routes outside apiRouter #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
changed the title
|
Also remember to update |
OtterleyW
force-pushed
the
move-oidc-routes-outside-basic-auth
branch
2 times, most recently
from
606b0d6
to
2b8517f
Compare
lyyder
reviewed
Jan 13, 2021
server/index.js
Outdated
Comment on lines
141
to
143
| // Use basic authentication when not in dev mode. This is | ||
| // intentionally after the static middleware to skip basic auth for | ||
| // static resources. |
There was a problem hiding this comment.
This could now mention that this is after static middleware and /.well-known endpoints as those will bypass basic auth.
lyyder
approved these changes
Jan 13, 2021
OtterleyW
force-pushed
the
move-oidc-routes-outside-basic-auth
branch
from
2b8517f
to
a73dca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move well-known/* endpoints related to OIDC proxy setup from
apiRouterto newwellKnownRouterso that they can be enabled outside the basic auth setup (e.g. ins staging environment). It also makes it simpler to set the identity provider URL, because we can drop the/apipart of the path.We need to add the new
wellKnownRouterto bothserver/index.jsandserver/apiServer.jsbecause these routes are no longer handled inapiRouterbut we want to be able to use them with bothyarn run devandyarn run dev-servercommands.This PR also renames the environment variable
RSA_SECRET_KEYtoRSA_PRIVATE_KEYfor consistency.