In-app linking to the current page created unnecessary update #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
changed the title
Gnito
force-pushed
the
fix-same-page-double-rendering
branch
from
09ba3e0
to
92acc89
Compare
Gnito
force-pushed
the
fix-same-page-double-rendering
branch
from
92acc89
to
9d780b2
Compare
This was referenced Dec 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handleLocationChanged call is also the root cause for the previous double rendering after full page refresh: #1380
(Although, that PR was a good step to uncouple Router and Redux store - it fixed the full page load and improved the debuggability of this issue.)
Can be debugged by adding a breakpoint to componentDidUpdate and clicking About page link in the footer.