Add timeout for geolocation.getCurrentPosition call #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
reviewed
Dec 7, 2020
| @@ -104,12 +104,18 @@ export const userLocation = () => | |||
| return; | |||
| } | |||
|
|
|||
| const options = { | |||
There was a problem hiding this comment.
Where are these options coming from? Why do we need e.g. enableHighAccuracy to be true? I think having some kind of code comment to explain would be nice
There was a problem hiding this comment.
@OtterleyW Good point. 👍
They actually come from here: https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition
I thought that "enableHighAccuracy: true" is a better default for templates since using false gave me a position that was 1km off.
OtterleyW
approved these changes
Dec 7, 2020
Gnito
force-pushed
the
add-timeout-for-getcurrentposition
branch
from
4315347
to
9c57a79
Compare
This was referenced Dec 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.