BookingUnitType config.js variable needed more comments #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
commented
Jun 29, 2020
| const unitType = 'line-item/night'; | ||
| // This bookingUnitType needs to be one of the following: | ||
| // line-item/night, line-item/day or line-item/units | ||
| const bookingUnitType = 'line-item/night'; |
There was a problem hiding this comment.
I changed the name so that it's in sync with the config.js variable (in web app).
This was referenced Jul 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds more comments about how to change booking unit type.
I.e. the new API server/proxy creates it a bit more work for people who want to change the unit type from ´line-item/night´ to ´line-item/day´.
We could also pass the bookingUnitType variable among bookingData to client app's server for flexible pricing calculations, but