Remove string cleaning from state-saved values. #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
commented
May 12, 2020
| const errorsClearedFromInputs = inputsNeeded.map(inputType => { | ||
| const input = prevState[inputType]; | ||
| return { ...input, error: null }; | ||
| }); |
There was a problem hiding this comment.
This code actually creates another set of input values to state - it's about array vs object: state[0] instead of overwriting state[inputType]. Reducer would easily solve this, but in the end, this is dead code - error clearing is done earlier.
|
LGTM! Remember to update the changelog |
This was referenced May 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This StripeBankAccountTokenInputField component is very old code (in a sense that there has been a lot of Stripe iteration and addition of new countries) - we should probably rewrite this component at some point. It's not even following our pretty old convention of naming Final Form field components as Field*.
This PR removes:
String cleaning for state-saved values.
It is done only on code values (bank codes, routing numbers, account-number, etc.) sent to Stripe.
I wonder if that formatted code was originally used for some error printing (i.e. sent values).
Removed
errorsClearedFromInputsstate handling after the async call was made.This was dead code and just caused saving of duplicate info to state.