Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search filter UI #1280

Merged
merged 9 commits into from
Mar 30, 2020
Merged

Improve search filter UI #1280

merged 9 commits into from
Mar 30, 2020

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Mar 27, 2020 •
edited
Loading

This PR improves the search page sorting controls for different screen sizes.

Mobile

Screenshot 2020-03-30 at 13 31 54

Desktop

Screenshot 2020-03-30 at 13 32 14

@kpuputti kpuputti temporarily deployed to sharetribe-starter-app March 30, 2020 09:18 Inactive
@kpuputti kpuputti temporarily deployed to sharetribe-starter-app March 30, 2020 10:33 Inactive
@kpuputti kpuputti marked this pull request as ready for review March 30, 2020 10:34
Gnito
Gnito approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise: LGTM

Gnito
Gnito requested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

src/components/MenuContent/MenuContent.css Outdated Show resolved Hide resolved
@kpuputti kpuputti merged commit db7c1e7 into master Mar 30, 2020
@kpuputti kpuputti deleted the search-filter-styles branch March 30, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Gnito requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpuputti @Gnito