Reorganize default search filters #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
Mar 20, 2020
| @@ -101,7 +104,7 @@ class SearchFiltersPanelComponent extends Component { | |||
| // if no option is passed, clear the selection for the filter | |||
| const currentQueryParams = option | |||
| ? { ...mergedQueryParams, [urlParam]: option } | |||
| : omit(mergedQueryParams, urlParam); | |||
| : { ...mergedQueryParams, [urlParam]: null }; | |||
There was a problem hiding this comment.
Don't remove omit. (I assume that this will add URL parameter category=null&amenities=null)
There was a problem hiding this comment.
Nope, this was a bug fix. Clearing the filter didn't work without this. It removes the param from the URL correctly.
Gnito
reviewed
Mar 20, 2020
| @@ -43,7 +43,7 @@ class MainPanel extends Component { | |||
|
|
|||
| const isSearchFiltersPanelOpen = !!secondaryFilters && this.state.isSearchFiltersPanelOpen; | |||
|
|
|||
| const filters = merge(primaryFilters, secondaryFilters); | |||
| const filters = merge({}, primaryFilters, secondaryFilters); | |||
Gnito
requested changes
Mar 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the default search filters in the search page. The category and amenities filters are moved from primary filters to secondary filters under the "More filters" panel.
This is mainly for making more space to the UI in preparation for the sorting controls.
Before
After