Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass invalid prop to Final Form #1255

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Don't pass invalid prop to Final Form #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a274496
Don't pass invalid prop to Final Form
Gnito Feb 3, 2020
ab252f8
Update Changelog
Gnito Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ way to update this template, but currently, we follow a pattern:

---

## Upcoming version 2019-XX-XX
## Upcoming version 2020-XX-XX

## [v4.1.0] 2020-02-03

- [fix] Remove unused 'invalid' prop that breaks some versions of Final Form
[#1255](https://github.com/sharetribe/ftw-daily/pull/1255)
- [fix] Fix `console.warn` functions. [#1252](https://github.com/sharetribe/ftw-daily/pull/1252)
- [fix] Add missing countries (e.g. MX and JP) to `StripeBankAccountTokenInput` validations.
- [add] Add missing countries (e.g. MX and JP) to `StripeBankAccountTokenInput` validations.
[#1250](https://github.com/sharetribe/ftw-daily/pull/1250)

## [v4.0.0] 2019-12-19
Expand Down
4 changes: 1 addition & 3 deletions src/forms/PaymentMethodsForm/PaymentMethodsForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* It's also handled separately in handleSubmit function.
*/
import React, { Component } from 'react';
import { bool, func, object, string } from 'prop-types';
import { func, object, string } from 'prop-types';
import { FormattedMessage, injectIntl, intlShape } from '../../util/reactIntl';
import { Form as FinalForm } from 'react-final-form';
import classNames from 'classnames';
Expand Down Expand Up @@ -284,7 +284,6 @@ PaymentMethodsForm.defaultProps = {
rootClassName: null,
inProgress: false,
handleSubmit: null,
invalid: false,
addPaymentMethodError: null,
deletePaymentMethodError: null,
createStripeCustomerError: null,
Expand All @@ -295,7 +294,6 @@ PaymentMethodsForm.defaultProps = {
PaymentMethodsForm.propTypes = {
formId: string,
intl: intlShape.isRequired,
invalid: bool,
handleSubmit: func,
addPaymentMethodError: object,
deletePaymentMethodError: object,
Expand Down