Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure booking transition exists #1131

Merged
merged 4 commits into from
Jul 8, 2019
Merged

Conversation

Gnito
Copy link
Contributor

@Gnito Gnito commented Jul 5, 2019

Ensure that enquiry has a correct transition when a customer tries to book the listing.

This might happen with process changes (e.g. when changing from previous default to SCA process)

Example:
If an enquiry is started with "preauth-with-nightly-booking/release1" and then client app is updated to use "sca-nightly-booking/release1", there is a possibility that enquiry-transactions exists. In that case, CheckoutPage can't process the tx since the codebase is updated. The enquiry is tied to an old unsupported process.

Instead of book-button, we show text that says: "Go to {listingLink} to book the listing."

@Gnito Gnito requested a review from OtterleyW July 5, 2019 14:52
Copy link
Contributor

@OtterleyW OtterleyW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OtterleyW OtterleyW merged commit 423a920 into master Jul 8, 2019
@OtterleyW OtterleyW deleted the ensure-booking-transition-exists branch July 8, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants