Testing CRA 3 update #1081
Merged
Testing CRA 3 update #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
cra3-update
branch
3 times, most recently
from
db34632
to
3ed042a
Compare
Gnito
commented
May 8, 2019
| "smoothscroll-polyfill": "^0.4.0", | ||
| "source-map-support": "^0.5.9", | ||
| "url": "^0.11.0" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-jest": "24.7.1", |
There was a problem hiding this comment.
There was a strange transient dependency problem without this. So, I had to include it as explicit dev-dependency.
Similar issue (but unrelated package): timarney/react-app-rewired#388
Eslint-plugin rules of hooks assumed that useInitialValues was actually a wrongly called hook
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing how CRA v3.0.0 works with FTW. Check also changelog from CRA fork
Reserve use* function naming pattern for React Hooks. (For some reason, Rules of Hooks eslint plugin didn't like our
useInitialValuesfunction (so, we decided to rename it and reserve use* function names for Hooks)Recent SDK update changed the proptypes for snapshots.
Update scripts/config.js after Prettier version bump
Remove unnecessary audit exceptions