Skip to content

Commit

Permalink
Merge pull request #906 from sharetribe/default-predictions-prop
Browse files Browse the repository at this point in the history
Disable default predictions in listing editing wizard
  • Loading branch information
lyyder committed Aug 22, 2018
2 parents cab54b5 + d4d4ac9 commit 8c08441
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,11 @@ class LocationAutocompleteInputImpl extends Component {

currentPredictions() {
const { search, predictions: fetchedPredictions } = currentValue(this.props);
const { useDefaultPredictions } = this.props;
const hasFetchedPredictions = fetchedPredictions && fetchedPredictions.length > 0;
const showDefaultPredictions = !search && !hasFetchedPredictions && useDefaultPredictions;

return !search && !hasFetchedPredictions ? defaultPredictions : fetchedPredictions;
return showDefaultPredictions ? defaultPredictions : fetchedPredictions;
}

// Interpret input key event
Expand Down Expand Up @@ -487,6 +489,7 @@ LocationAutocompleteInputImpl.defaultProps = {
predictionsAttributionClassName: null,
validClassName: null,
placeholder: '',
useDefaultPredictions: true,
meta: null,
inputRef: null,
};
Expand All @@ -502,6 +505,7 @@ LocationAutocompleteInputImpl.propTypes = {
predictionsAttributionClassName: string,
validClassName: string,
placeholder: string,
useDefaultPredictions: bool,
input: shape({
name: string.isRequired,
value: oneOfType([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export const EditListingLocationFormComponent = props => (
name="location"
label={titleRequiredMessage}
placeholder={addressPlaceholderMessage}
useDefaultPredictions={false}
format={null}
valueFromForm={values.location}
validate={composeValidators(
Expand Down

0 comments on commit 8c08441

Please sign in to comment.