Skip to content

Commit

Permalink
Merge pull request #845 from sharetribe/final-form-migration
Browse files Browse the repository at this point in the history
Migrate rest of forms to Final Form
  • Loading branch information
lyyder authored Jun 6, 2018
2 parents 4a0db24 + cdfd6e0 commit 6be5c31
Show file tree
Hide file tree
Showing 53 changed files with 449 additions and 1,298 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ way to update this template, but currently, we follow a pattern:

---

## Upcoming version
## v1.0.0

* [change] Migrate remaining Redux Forms to Final Form. Also now all the form components can be
found in the src/forms folder. Remove redux-form from the dependencies.
[#845](https://github.com/sharetribe/flex-template-web/pull/845)
* [fix] Extract and fix missing information reminder modal from Topbar
[#846](https://github.com/sharetribe/flex-template-web/pull/846)
* [fix] Add missing styles for ModalMissingInformation from Topbar
Expand Down
4 changes: 0 additions & 4 deletions docs/folder-structure.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ this folder contains only page-level components and one common component: Topbar
Forms are in their own folder since they are using a special library to handle validations, errors,
internal state, etc.

_**NOTE:** Currently, we are migrating to
[🏁 Final Form](https://github.com/final-form/react-final-form) (away from
[Redux Form](http://redux-form.com/))._

## server/

* `server/index.js` handles server-side rendering (SSR). Built with [Express](http://expressjs.com)
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"react-redux": "^5.0.7",
"react-router-dom": "^4.2.2",
"redux": "^3.7.2",
"redux-form": "^7.3.0",
"redux-thunk": "^2.2.0",
"sanitize.css": "^5.0.0",
"sharetribe-scripts": "1.1.2",
Expand Down
4 changes: 0 additions & 4 deletions src/components/FieldBirthdayInput/FieldBirthdayInput.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
/**
* NOTE this component is part of react-final-form instead of Redux Form.
*/

import React, { Component } from 'react';
import { func, instanceOf, object, node, string, bool } from 'prop-types';
import { Field } from 'react-final-form';
Expand Down
4 changes: 0 additions & 4 deletions src/components/FieldCheckbox/FieldCheckbox.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
/**
* NOTE this component is part of react-final-form instead of Redux Form.
*/

import React from 'react';
import { node, string } from 'prop-types';
import classNames from 'classnames';
Expand Down
4 changes: 0 additions & 4 deletions src/components/FieldCheckboxGroup/FieldCheckboxGroup.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
/**
* NOTE this component is part of react-final-form instead of Redux Form.
*/

/*
* Renders a group of checkboxes that can be used to select
* multiple values from a set of options.
Expand Down
4 changes: 0 additions & 4 deletions src/components/FieldCurrencyInput/FieldCurrencyInput.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
/**
* NOTE this component is part of react-final-form instead of Redux Form.
*/

/**
* CurrencyInput renders an input field that format it's value according to currency formatting rules
* onFocus: renders given value in unformatted manner: "9999,99"
Expand Down
68 changes: 0 additions & 68 deletions src/components/FieldGroupCheckbox/FieldCheckbox.css

This file was deleted.

91 changes: 0 additions & 91 deletions src/components/FieldGroupCheckbox/FieldCheckbox.js

This file was deleted.

28 changes: 0 additions & 28 deletions src/components/FieldGroupCheckbox/FieldGroupCheckbox.css

This file was deleted.

108 changes: 0 additions & 108 deletions src/components/FieldGroupCheckbox/FieldGroupCheckbox.example.js

This file was deleted.

Loading

0 comments on commit 6be5c31

Please sign in to comment.