Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default predictions in listing editing wizard #906

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

lyyder
Copy link
Contributor

@lyyder lyyder commented Aug 22, 2018

Adds a prop to LocationAutocompleteInputImpl that can be passed to LocationAutocompleteInput to disable default predictions in a location input.

@lyyder
Copy link
Contributor Author

lyyder commented Aug 22, 2018

One option here would also be that the default predictions list could be passed as prop and it would override the one from the geocoder. This way for example only current location could be used in the listing wizard. Downside in that would be that the geocoder specific prediction schema would spread around.

@kpuputti
Copy link
Contributor

The default prediction configuration will change in #900 and will be independent of the geocoder in use. However, current location cannot really be used in the listing wizard as it only returns coordinates, not address or bounds. So this solution is fine IMO.

@lyyder lyyder merged commit 8c08441 into master Aug 22, 2018
@lyyder lyyder deleted the default-predictions-prop branch August 24, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants