Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies in examples #595

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

curran
Copy link
Contributor

@curran curran commented Mar 2, 2023

Closes #594

@coveralls
Copy link

coveralls commented Mar 2, 2023

Coverage Status

Coverage: 97.507% (+0.04%) from 97.471% when pulling f783dec on curran:upgrade-deps-in-examples into f4845fd on share:master.

@curran
Copy link
Contributor Author

curran commented Mar 2, 2023

Current status:

  • examples/counter Works fine
  • examples/counter-json1 Works fine
  • examples/leaderboard Build fails with error "Error: Plugin/Preset files are not allowed to export objects, only functions."
  • examples/rich-text Works fine
  • examples/rich-text-presence Build fails with error "Error: Can't walk dependency graph: Cannot find module 'ot-json0'"
  • examples/textarea Works fine

@curran
Copy link
Contributor Author

curran commented Mar 2, 2023

Current status:

  • examples/counter Works fine
  • examples/counter-json1 Works fine
  • examples/leaderboard Works fine
  • examples/rich-text Works fine
  • examples/rich-text-presence Build fails with error "Error: Can't walk dependency graph: Cannot find module 'ot-json0'"
  • examples/textarea Works fine

@curran
Copy link
Contributor Author

curran commented Mar 2, 2023

Current status:

@curran
Copy link
Contributor Author

curran commented Mar 9, 2023

Current status:

@curran
Copy link
Contributor Author

curran commented Mar 9, 2023

Current status:

  • examples/counter Works fine
  • examples/counter-json1 Works fine
  • examples/leaderboard Works fine
  • examples/rich-text Works fine
  • examples/rich-text-presence Works fine
  • examples/textarea Works fine

@alecgibson alecgibson merged commit 404cde5 into share:master Mar 28, 2023
@curran
Copy link
Contributor Author

curran commented Mar 29, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Dependencies in Examples
3 participants