Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test coverage for queryPollDoc #319

Merged
merged 1 commit into from
Oct 28, 2019
Merged

add test coverage for queryPollDoc #319

merged 1 commit into from
Oct 28, 2019

Conversation

nateps
Copy link
Contributor

@nateps nateps commented Oct 25, 2019

Implement additional BasicQueryableMemoryDB implementation methods, so that code paths in query-emitter are exercised by tests

@nateps
add test coverage for queryPollDoc
7b06e96 
implmenet additional BasicQueryableMemoryDB implementation methods, so that code paths in query-emitter are exercised by tests
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 96.778% when pulling 7b06e96 on test-query-poll-doc into c5d7ca2 on master.

ericyhwang
ericyhwang approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@ericyhwang ericyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Change is exclusively in test code, and test coverage went up as desired.

@nateps nateps merged commit 7c21f49 into master Oct 28, 2019
@nateps nateps deleted the test-query-poll-doc branch October 28, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nateps @coveralls @ericyhwang