Linter fixes #302
Merged
Linter fixes #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2019 15:25
This change addresses three things:
1. Move us from `jshint` to `eslint` (which is the more commonly used
linter)
2. Fix our linting glob patterns, which currently only address files
at the top of their respective directories (and ignore all files in
subdirectories)
3. Enforce stricter linting rules, based roughly on the [Google][1]
rules
[1]: https://github.com/google/eslint-config-google
Large indentation fixes were skipped in the previous commit in order to keep the diff a bit less noisy. This change purely removes the eslint ignore comments, and fixes the indentation in those files.
ericyhwang
reviewed
Jul 10, 2019
alecgibson
commented
Jul 10, 2019
alecgibson
commented
Jul 10, 2019
nateps
reviewed
Jul 10, 2019
added 4 commits
July 15, 2019 12:29
This change actively extends the Google ESLint config. We move the config into a `.js` file so that we can add comments about particular rules that we've overridden. This change also fixes some trailing comma and indentation linting errors.
This change uses our `.gitignore` file to define which files ESLint should ignore, so that all of our committed JavaScript has a consistent style.
This change makes some linting review markups: - pre-comupte long, concatenated strings - only allow one statement per line
alecgibson
pushed a commit
to share/sharedb-mongo
that referenced
this pull request
Jul 18, 2019
This change adds linting through `eslint`, with config read across from [ShareDB][1] [1]: share/sharedb#302
alecgibson
pushed a commit
to share/sharedb-mongo
that referenced
this pull request
Jul 18, 2019
This change adds linting through `eslint`, with config read across from [ShareDB][1] [1]: share/sharedb#302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses three things:
jshinttoeslint(which is the more commonly usedlinter)
at the top of their respective directories (and ignore all files in
subdirectories)
rules
Note that the change is split into two commits:
eslintand fixes most of the issues