fix: Uncaught TypeError: Illegal invocation in chrome 51

[qinyang912]

in chrome 51, will throw error

[coveralls]

Coverage increased (+0.005%) to 95.914% when pulling 7c729d7 on qinyang912:master into ca4816f on share:master.

[alecgibson]

Nice, but shouldn't this be:

Suggested change

	logger[method] = overrides[method].bind(overrides);
	logger[method] = overrides[method].bind(overrides[method]);

And by that point, maybe we can tidy up the loop a bit:

SUPPORTED_METHODS.forEach(function (method) {
  var override = overrides[method];
  if (typeof override === 'function') {
    logger[method] = override.bind(override);
  }
});

[qinyang912]

should be this:

SUPPORTED_METHODS.forEach(function (method) {
  var override = overrides[method];
  if (typeof override === 'function') {
    logger[method] = override.bind(overrides);
  }
});

[alecgibson]

Why bind to the object of overrides rather than the function itself? Or actually, maybe more accurate would be:

logger[method] = override.bind(logger);

[qinyang912]

you can try these code in chrome 51:

var logger = {};
var override = console.log;
logger.log = override.bind(override);
logger.log('test')

and

var logger = {}
var override = console.log
logger.log = override.bind(logger)
logger.log('test')

both throw error

[qinyang912]

but this is successful:

var logger = {};
var override = console.log;
logger.log = override.bind(console);
logger.log('test');

[alecgibson]

You're getting that error because of this issue with Chrome. The correct thing to do is:

var logger = {};
var override = console.log.bind(console);
logger.log = override;
logger.log('test');

[alecgibson]

I'm closing this, because the correct usage should be:

ShareDB.logger.setMethods({
  log: console.log.bind(console),
});

[alecgibson]

Sorry, I just realised you mean this happens with the default Logger?

I'm not sure that arbitrarily setting the this argument to the provided object is valid. Instead, we should change how we set the default:

function Logger() {
  var defaultMethods = {};
  SUPPORTED_METHODS.forEach(function (method) {
    // Deal with Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=179628
    defaultMethods[method] = console[method].bind(console);
  });
  this.setMethods(defaultMethods);
}

[qinyang912]

@alecgibson Yes, I mean the default logger.. 😄

[ericyhwang]

Thanks! Published in [email protected]