Add new "reply" middleware action #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "reply" middleware is called just before the backend is about to reply to a client. It's the flip side of the existing "receive" middleware action. The middleware function gets a context with properties: - request - reply - action (always `'reply'` for this middleware) - agent - backend
nateps
reviewed
Mar 27, 2019
lib/agent.js
Outdated
| this.send(request); | ||
| request.error = getReplyErrorObject(err); | ||
| var middlewareContext = {request: request, reply: request}; | ||
| backend.trigger(backend.MIDDLEWARE_ACTIONS.reply, agent, middlewareContext, function(_err) { |
There was a problem hiding this comment.
If we have an error, let's not emitted the middleware event instead.
nateps
approved these changes
Mar 27, 2019
|
Released in [email protected] |
|
What is the purpose of the "reply" middleware? I see there is no documentation at all added in this PR. The tests serve as the documentation. |
Whatever, really - a couple example use-cases:
It's a pretty low-level middleware, sitting just above the messaging layer, similar to the existing 'receive' middleware.
I indeed forgot to update the README, thanks for the reminder! Just made a new PR for it: #279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "reply" middleware is called just before the backend is about to send a non-error reply to a client.
It's the flip side of the existing "receive" middleware action.
The middleware function gets a context with these properties:
'reply'for this middleware)