In Doc._clearInflightOp, clear inflightOp before calling callbacks #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes double-callback issue for chained op submissions where the second op is invalid: #272
|
Published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a double-callback issue for chained op submissions, where if the second op is invalid, the first op's callback gets called twice:
#272
Doc._hardRollbackalready does takes a similar approach of clearing local Doc state prior to calling callbacks, and Nate expressed his agreement with this fix today at the PR review meeting.Thanks to @nickasd and @alecgibson for developing the test case that reproduces the issue!