Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For readSnapshots middleware, add method and parameter properties to first parameter #263

Merged
merged 5 commits into from
Feb 14, 2019

Commits on Jan 16, 2019

  1. For readSnapshots middleware, add requestMethod and requestParams pro…

    …perties
    
    The "readSnapshots" middleware function can now look like this:
    
    ```
    function(request, next) {
      let {
        collection,
        snapshots,
        requestMethod, // 'fetch', 'query', etc.
        requestParams, // object whose shape can vary
        snapshotType,
        agent
      } = request;
    }
    ```
    ericyhwang committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    5dd070b View commit details
    Browse the repository at this point in the history
  2. Code review changes for readSnapshots middleware

    - requestMethod -> method, requestParams -> parameters
    - Distinguish methods 'queryFetch' and 'querySubscribe'
    ericyhwang committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    58e29e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Configuration menu
    Copy the full SHA
    57c8598 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Configuration menu
    Copy the full SHA
    15a438f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e12683 View commit details
    Browse the repository at this point in the history